Repository navigation
docs(WO17): ts 111 closed — fp16-IO root cause, runtime defense merged - #438
Merged
Merged
Conversation
… merged; SPEC fp32-IO line owner-flagged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ts #111 closed with the real root cause: fp16 graph I/O meeting the onnxruntime-node binding on Node ≥ 24 (Float16Array feeds read as 0 bytes by the N-API binding) — the WO79 fp32-IO repacks masked it after the issue was filed. The runtime now rejects fp16 feeds with a named artifact-contract error, locked by a 1KB regression fixture on both runtime branches (PR #134 merged, all CI green). Owner-flagged: SPEC.md should mandate fp32 graph I/O to make the contract normative.